Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken logo image #4336

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Fix broken logo image #4336

merged 1 commit into from
Nov 17, 2021

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Nov 15, 2021

Bug

Fixes: NuGet/Home#11390

Regression? Last working version:

Description

NuGet logo on NuGet.Client repo is broken.
image.png

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@mairaw mairaw requested a review from a team as a code owner November 15, 2021 20:29
@ghost ghost added the Community PRs created by someone not in the NuGet team label Nov 15, 2021
@erdembayar
Copy link
Contributor

@mairaw
Please create tracking issue at NuGet/Home and fill out template.
image

@mairaw
Copy link
Contributor Author

mairaw commented Nov 16, 2021

@erdembayar can you do this part? Not sure how to answer some of those required questions for this simple fix.

@nkolev92
Copy link
Member

The changes are technically described in the PR.
I've checked the last 2 boxes about the tests.

I think we're just missing an issue.

it's our policy that every commit has a respective issue.

@mairaw
Copy link
Contributor Author

mairaw commented Nov 16, 2021

Sure @nkolev92 but the issue template has some required fields that are not applicable to this simple change and I don't know how to fill that out. Should you have a N/A for this question or do I just pick a random one?
image

@nkolev92
Copy link
Member

nkolev92 commented Nov 16, 2021

Seems like @erdembayar handled it and created an issue.

Using the blank template is ok for issues that are not necessarily related to anything already listed.

@erdembayar erdembayar merged commit 84fec6f into NuGet:dev Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PRs created by someone not in the NuGet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken NuGet logo image
3 participants