-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Arcade-powered source-build wrapper. #4105
Conversation
@dominoFire Could I get the CI label on this please? |
ping @nkolev92 @dominoFire for the CI label please. |
fc7d2f5
to
00a41fe
Compare
fc5e970
to
64135a2
Compare
@dominoFire I merged #3945 into this one so I closed that one. cc @dseefeld and @MichaelSimons if you'd like to review. |
@dominoFire @nkolev92 @zivkan Is there any other changes that need to be made before you can merge this? |
@crummel Out of curiosity, why is Furthermore, this repo is mirrored to Azure DevOps' DevDiv instance, which has "Case enforcement" enabled, and therefore this change might break mirroring. |
…tch to accomplish the same thing.
This is due to an Arcade issue. I've reverted this for now and put in a source-build patch that does it instead - I can remove this patch when we bring in intermediate package publishing to Nuget. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's hope we can get a non-flaky CI build soon.
Thanks for all your help getting this in! |
This adds a source-build project in eng/source-build. This project pulls in a recent version of Arcade that supports the ArPow targets, restores arcade tooling (so we make source-build tasks available), builds NuGet in the source-build fashion (Restore/Build/Pack XPlat), and then collects the built NuGet packages into source-build intermediate packages.
Remaining work:
I wanted to get this in as an intermediate step because the dev workflow for source-build does work now.
There are a couple NuGet source changes I made:
Bug
Fixes: dotnet/source-build#2069.
Regression? No. Last working version: N/A
Description
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
This adds a source-build CI leg which is effectively the test of the source-build changes.
Documentation