Observer status code in V2FeedParser #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good, verified against ProGet and NuGet.Server, works well |
|
Great tests and fix! 🚀 |
joelverhagen
force-pushed
the
jver-statuscode
branch
from
d5c89a4 to
df83b5d
Compare
|
Related: NuGet/Home#2298 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three endpoints hit here with slightly different HTTP status code requirements.
/api/v2/Search- expects only 200. Everything else should cause an exception. 404 is never expected./api/v2/FindPackagesById- expects only 200. Everything else should cause an exception. 404 is never expected./api/v2/Packages(Id='...',Version='...')- expects 200 for success and 404/204 for no match. Everything else should cause an exception.Verified on NuGet.org functionality.
@zhili1208 @emgarten @johnataylor @yishaigalatzer