Adding CMD wrappers for PS1 scripts. #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srdjanjovcic
requested review from
aortiz-msft,
cristinamanum,
dominoFire,
donnie-msft,
dtivel,
heng-liu,
kartheekp-ms,
nkolev92,
rrelyea,
zivkan and
zkat
as code owners
nkolev92
approved these changes
May 4, 2020
|
For future PRs, I'd recommend using our remote (now you should have the right), it makes it easier to run the CI :) |
zivkan
approved these changes
May 4, 2020
|
I'll just force merge this no need to kick off a CI actually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#9519
Regression: No
Fix
Details: Providing tiny CMD wrappers around PS1 scripts help usability of NuGet.Client repo from CMD windows.
Testing/Validation
Tests Added: No
Reason for not adding tests: Not a product issue.
Validation: configure.cmd/build.cmd/runTests.cmd correctly invoke wrapped PS1 scripts