Allow the project to provide the runtime identifier graph #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
changed the title
nkolev92
requested review from
dtivel,
dominoFire,
donnie-msft,
zivkan and
heng-liu
zivkan
reviewed
Jun 11, 2019
src/NuGet.Core/NuGet.Commands/RestoreCommand/ProjectRestoreCommand.cs
Outdated
Show resolved
Hide resolved
test/NuGet.Core.FuncTests/NuGet.Commands.FuncTest/RestoreCommandTests.cs
Outdated
Show resolved
Hide resolved
test/NuGet.Clients.Tests/NuGet.CommandLine.Test/compiler/resources/runtime.json
Outdated
Show resolved
Hide resolved
|
@zivkan Addressed all but the partial class comments. |
zivkan
approved these changes
Jun 13, 2019
src/NuGet.Core/NuGet.Commands/RestoreCommand/ProjectRestoreCommand.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Commands/RestoreCommand/ProjectRestoreCommand.cs
Outdated
Show resolved
Hide resolved
test/NuGet.Core.Tests/NuGet.ProjectModel.Test/PackageSpecCloningTests.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#7351
Regression: No
Fix
Details: Spec at https://github.com/NuGet/Client.Engineering/pull/96.
Note that there's an internal spec review at 06/11/19. So please hold off review until then.
The runtime graph used to be provided through a versioned package. This adds the ability to specify it through the project itself without a package.
Testing/Validation
Tests Added: Yes
Reason for not adding tests:
Validation: