Plugins: propagate plugin exception #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtivel
requested review from
dominoFire,
nkolev92,
zivkan,
heng-liu and
donnie-msft
dtivel
commented
May 2, 2019
dtivel
commented
May 2, 2019
| @@ -87,9 +87,9 @@ Invoke-BuildStep 'Cleaning package cache' { | |||
| -skip:(-not $CI) ` | |||
| -ev +BuildErrors | |||
|
|
|||
| Invoke-BuildStep 'Running /t:RestoreVS15' { | |||
| Invoke-BuildStep 'Running /t:RestoreVS' { | |||
There was a problem hiding this comment.
These changes were overlooked by #2832.
There was a problem hiding this comment.
My bad, we don't use these scripts in our build at all, so I didn't even think about them.
This was referenced May 2, 2019
nkolev92
approved these changes
May 2, 2019
| @@ -87,9 +87,9 @@ Invoke-BuildStep 'Cleaning package cache' { | |||
| -skip:(-not $CI) ` | |||
| -ev +BuildErrors | |||
|
|
|||
| Invoke-BuildStep 'Running /t:RestoreVS15' { | |||
| Invoke-BuildStep 'Running /t:RestoreVS' { | |||
There was a problem hiding this comment.
My bad, we don't use these scripts in our build at all, so I didn't even think about them.
dtivel
force-pushed
the
dev-dtivel-plugin-exception-details
branch
from
5e57944 to
832e288
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve NuGet/Home#8057.
Ideally,
NuGet.Common.ILoggerwould have a method that would take an exception and log the callstack depending on the logging verbosity level:However, that change is a large, breaking change and out of scope for fixing NuGet/Home#8057.
As it currently stands, it's left to the caller of an
ILoggerimplementation to determine whether or not to log a callstack based on the logging verbosity level, but the logging verbosity level is unavailable to the caller.The simple solution now is to log the callstack with
ILogger.LogDebug(…)and leave it to the logger to decide whether or not to log debug events.