Clean up --verbosity minimal logging #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -247,7 +249,7 @@ public static int Main(string[] args) | |||
| } | |||
| catch (Exception e) | |||
| { | |||
| EnsureLog(verbosity); | |||
| EnsureLog(GetLogLevel(verbosity)); | |||
There was a problem hiding this comment.
Is this call redundant? I saw it is already invoked as the first thing on the execution body. Also, can we just call once right after we retrieve the verbosity above?
I am wiring up the "push", so need to understand this part better.
There was a problem hiding this comment.
If any exception occurs outside of the restore command or before the restore command is executed, this EnsureLog is necessary. Note that this has to be run after app.Execute which takes the string[] args and parses them in to the various CommandOption instances.
|
|
joelverhagen
force-pushed
the
jver-2069
branch
from
f515e53
to
a84dc1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committing restore...to Information level (not Minimal).Minimallevel (that is, config files used, feeds used, and install counts).Minimalto the--verbosityhelp text.This is responding to NuGet/Home#2069.
@emgarten @zhili1208 @deepakaravindr