PackageVersion property for .NET Core projects #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emgarten
reviewed
Jan 25, 2017
| .Cast<IVsTargetFrameworkInfo>() | ||
| .Select(tfm => GetPropertyValueOrNull(tfm.Properties, propertyName)) | ||
| .Distinct() | ||
| .SingleOrDefault(); |
There was a problem hiding this comment.
I would say this is the most correct, but will it be too difficult for the user to figure out if this silently returns null and 1.0.0 is used as the project version?
emgarten
approved these changes
Jan 25, 2017
natidea
approved these changes
Jan 25, 2017
jainaashish
approved these changes
Jan 25, 2017
Resolves NuGet/Home#3901. Acquire package version property for a .NET Core project from the `IVsProjectRestoreInfo` as provided via the Nominate API call. Although the `$(PackageVersion)` property shouldn't differ between different TFMs current API design assumes all project properties will be evaluated per each TFM. As a result `SolutionRestoreService` expects to get the same value of package version defined in each TFM property bag. Otherwise `InvalidOperationException` will be thrown.
alpaix
force-pushed
the
package-version
branch
from
367ae05 to
12494ae
Compare
This was referenced Feb 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves NuGet/Home#3901.
Acquire package version property for a .NET Core project from the
IVsProjectRestoreInfoas provided via the Nominate API call.Although the
$(PackageVersion)property shouldn't differ betweendifferent TFMs current API design assumes all project properties will be
evaluated per each TFM.
As a result
SolutionRestoreServiceexpects to get thesame value of package version defined in each TFM property bag.
Otherwise
InvalidOperationExceptionwill be thrown.//cc @emgarten @jainaashish @mishra14 @rohit21agrawal @natidea @rrelyea