fix package path issues when packing content into non-default locations inside nupkg #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
emgarten
reviewed
Jan 19, 2017
| var setOfTargetPaths = new HashSet<string>(targetPaths, StringComparer.Ordinal); | ||
| if (setOfTargetPaths.Remove("contentFiles" + Path.DirectorySeparatorChar) | ||
| if (setOfTargetPaths.Remove("contentFiles" + Path.DirectorySeparatorChar) |
There was a problem hiding this comment.
does this need to check for the AltDirectorySeparatorChar also?
There was a problem hiding this comment.
good catch, added it .
emgarten
approved these changes
Jan 19, 2017
| foreach (var targetPath in setOfTargetPaths) | ||
| { | ||
| var newTargetPath = Path.Combine(targetPath, identity); | ||
| // We need to do this because evaluuated identity in the above line of code can be an empty string |
There was a problem hiding this comment.
typo:
because evaluuated identity
-> because the evaluated identity
rohit21agrawal
force-pushed
the
dev-ragrawal-packagepathfix
branch
from
7e324d5 to
5ca7f78
Compare
|
@emgarten i added tests with both / and \ |
rohit21agrawal
force-pushed
the
dev-ragrawal-packagepathfix
branch
from
5ca7f78 to
11467ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: NuGet/Home#4321
Added extensive test coverage for all possible input/output combinations of source path and packagepath.
CC: @rrelyea @emgarten @alpaix @mishra14 @jainaashish @nkolev92 @zhili1208