Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lib placeholder files are not added during VS restores #4629

Closed
emgarten opened this issue Feb 16, 2017 · 1 comment
Closed

Lib placeholder files are not added during VS restores #4629

emgarten opened this issue Feb 16, 2017 · 1 comment

Comments

@emgarten
Copy link
Member

emgarten commented Feb 16, 2017

Place holder dlls are added to the compile and runtime sections of project entries in project.assets.json. When a project is excluded to keep it from flowing transitively these place holders are replaced with _._ to signal that no assets should be used from these projects.

Currently this works for msbuild /t:restore and dotnet.exe restore but it is not showing up when restoring from Visual Studio.

The fix for this is to add these placeholders in when creating package specs for PackageReference and project.json projects in Visual Studio.

Example:

"compile": {
    "bin/placeholder/net451/a.dll": {}
}
@emgarten
Copy link
Member Author

This needs more investigation to find the impact, and the default behavior when this doesn't exist.

@emgarten emgarten modified the milestones: 4.1, 4.0.0 Mar 6, 2017
@rrelyea rrelyea modified the milestones: 4.3 - 3/6 thru 3/24, 4.1 Mar 10, 2017
emgarten added a commit to NuGet/NuGet.Client that referenced this issue Mar 21, 2017
This change moves the step to add placeholder files for transitive project detection from MSBuild into restore so that it will be applied to all restores. Previously only command line restores were getting this step.

NuGet/Home#4629
emgarten added a commit to NuGet/NuGet.Client that referenced this issue Mar 21, 2017
This change moves the step to add placeholder files for transitive project detection from MSBuild into restore so that it will be applied to all restores. Previously only command line restores were getting this step.

NuGet/Home#4629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants