Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron support #1859

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Electron support #1859

wants to merge 6 commits into from

Conversation

feznyng
Copy link
Contributor

@feznyng feznyng commented Nov 22, 2024

  • Added remote adapter class which takes a callback used to actually execute queries. Implementers can provide a callback using any transport they want. I've added an example using electron's IPC to the docs.
  • I'm coming from a Typescript background so unsure if the Flow types are correct.
  • This approach assumes arguments and response values passed to the adapter are serializable (Electron uses standard structured clone). Please let me know if this assumption is wrong. The alternative (and maybe better?) way is fully re-implementing the sqlite adapter but I'm trying to be lazy 😉.

Not really sure if this should be a draft or not, tests pass but I haven't added any extra for the new code. I won't have much time to work on this PR further but at the very least, might be helpful as reference for anyone trying to implement something similar.

@radex
Copy link
Collaborator

radex commented Nov 22, 2024

Very cool work! Thank you @feznyng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants