Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix json type return #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix json type return #20

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7534fe9
set type for json return
rskjetlein Aug 13, 2020
67eb54b
Revert "set type for json return"
rskjetlein Aug 13, 2020
0083edf
set type for json return
rskjetlein Aug 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker_pull.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ def progress_bar(ublob, nb_traits):
# last layer = config manifest - history - rootfs
if layers[-1]['digest'] == layer['digest']:
# FIXME: json.loads() automatically converts to unicode, thus decoding values whereas Docker doesn't
json_obj = json.loads(confresp.content)
json_obj = json.loads(confresp.content.decode('utf-8'))
del json_obj['history']
try:
del json_obj['rootfs']
Expand Down