Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in which passing in a weight vector with nonpositive elements would throw the following error:
Before this change, while the following lines of
decompose
did filter out the rows ofdata
with nonpositive weights (as well as missing values of the other variables in the formula)...Econometrics.jl/src/formula.jl
Lines 76 to 80 in f8751d1
... this wasn't being done for the
wts
vector itself, which was defined earlier using all rows of the dataset:Econometrics.jl/src/formula.jl
Line 59 in f8751d1
This same unfiltered weight vector was later passed into
FrequencyWeights(...)
with missing values, resulting in the error:Econometrics.jl/src/formula.jl
Lines 160 to 161 in f8751d1