Feature/pca #179
Feature/pca #179
Conversation
general/src/pca9539.c
Outdated
| HAL_StatusTypeDef pca9539_read_reg(pca9539_t *pca, uint8_t reg_type, | ||
| uint8_t *buf) { | ||
| /* | ||
| HAL_StatusTypeDef pca9539_read_reg(pca9539_t *pca, uint8_t reg_type, uint8_t *buf) { |
There was a problem hiding this comment.
need to remove HAL_Status_TypeDef to make this agnostic - those are just enums to ints so can replace with int
| typedef int(*I2C_WriteFuncPtr)( uint16_t address, uint8_t reg_type, | ||
| uint8_t data ); | ||
| typedef int(*I2C_ReadFuncPtr)( uint16_t address, uint8_t reg_type, | ||
| uint8_t data ); |
There was a problem hiding this comment.
nitpick but can we change names:
I2c write function ptr --> Write_Ptr
read func ptr ----> Read_Ptr
then the local versions from "local..." to just "read" and "write"
general/include/pca9539.h
Outdated
|
|
||
| // Two Function Pointers | ||
| WritePtr Write; | ||
| ReadPtr Read; |
There was a problem hiding this comment.
sorry more nitpick but just so all drivers are the same:
Write --> write
Read --> read
| uint8_t dev_addr) { | ||
| pca->i2c_handle = i2c_handle; | ||
| pca->dev_addr = dev_addr << 1u; /* shifted one to the left cuz STM says so */ | ||
| void pca9539_init(pca9539_t *pca, WritePtr writeFunc, |
There was a problem hiding this comment.
i2c Handle is STM HAL, so that should be removed here
There was a problem hiding this comment.
the i2c_handle member of the pca type can be removed too
general/src/pca9539.c
Outdated
| if (status) { | ||
| return status; | ||
| } | ||
| //*buf = (data & (1 << pin)) > 0; What to do with this? |
There was a problem hiding this comment.
i dont know without looking much what this does, but changing exisint stuff outside of HAL related info is not needed, so you can keep this logic the same as it was initially
…out code is unused and if included presents an error
| HAL_StatusTypeDef pca9539_write_reg(pca9539_t *pca, uint8_t reg_type, | ||
| uint8_t buf) { | ||
| //Errors in write_pin and read_pin functions if the commented code left in | ||
| //Variables within function are unused |
There was a problem hiding this comment.
the logic of this function has been changed, hence the errors. Take a look at the diff - the old code first read the state of the pin with a read call, then set data_new to the opposite state, and then wrote that back to the device. If you undo changes to that logic and keep it the same as it was u shoudlnt get any errors
UPDATED OCT 15
-Removed any notice of HAL driver
-Changed the names of pointers
Notes
Any other notes go here
Test Cases
-Test in Cerberus
To Do
Any remaining things that need to get done
-PR for Cerberus feature/pca
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
Closes #158 (issue #158 )