Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project runner #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

skywalkerisnull
Copy link

List of things I did:

  • The python scripts were not able to be imported into another python script if they had hyphens in their names, so all python scripts were renamed (most files have not been touched, only renamed)
  • DJI Phantom 4 FC330 camera was added
  • An importing proxy was created to allow for import into the project runner script. Now there is a single script that can run the project from end to end. A few TODOs were added as required and should be completed in the future.
  • The scripts that were required to be used in the standard project run have had a large function created, and an if __name__ == "__main__" added to still run from command line, and be called from other modules.
  • Try/Except loop added to a flakey module.

@skywalkerisnull skywalkerisnull marked this pull request as ready for review August 2, 2019 06:14
@skywalkerisnull
Copy link
Author

I think a future version of this I would make the command line arguments into an object (that also could be loaded from a config file of some description) and pass the object to each of the functions rather than the quick mechanism that I have used right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant