Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/handle native events #105

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Fix/handle native events #105

merged 6 commits into from
Nov 15, 2023

Conversation

Braggiouy
Copy link
Contributor

@Braggiouy Braggiouy commented Nov 13, 2023 •
edited
Loading

  • Documentation to be added (Modify / add feature to README.md)
  • Version Bump
  • Implementation to handle native events with shouldUseNativeEvents flag

Related Issue : #87

@Braggiouy Braggiouy added the enhancement New feature or request label Nov 13, 2023
@Braggiouy Braggiouy requested a review from a team November 13, 2023 16:28
@Braggiouy Braggiouy self-assigned this Nov 13, 2023
@Braggiouy Braggiouy marked this pull request as draft November 13, 2023 16:28
predikament
predikament reviewed Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@predikament predikament left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. ☺️

@Braggiouy Braggiouy marked this pull request as ready for review November 14, 2023 08:55
@Braggiouy Braggiouy linked an issue Nov 14, 2023 that may be closed by this pull request
An Option to Use Native DOM Events Instead of Synthetic Events #87
Closed
xavi160
xavi160 previously approved these changes Nov 14, 2023
View reviewed changes
predikament
predikament previously approved these changes Nov 14, 2023
View reviewed changes
asgvard
asgvard previously approved these changes Nov 15, 2023
View reviewed changes
@Braggiouy Braggiouy mentioned this pull request Nov 15, 2023
Closed
@Braggiouy Braggiouy dismissed stale reviews from asgvard, predikament, and xavi160 via a4207bd November 15, 2023 11:19
predikament
predikament previously approved these changes Nov 15, 2023
View reviewed changes
asgvard
asgvard previously approved these changes Nov 15, 2023
View reviewed changes
@Braggiouy Braggiouy dismissed stale reviews from asgvard and predikament via 4986279 November 15, 2023 12:39
@Braggiouy Braggiouy merged commit 80b4385 into main Nov 15, 2023
@Braggiouy Braggiouy deleted the fix/handle-native-events branch November 15, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@predikament predikament predikament approved these changes

@asgvard asgvard asgvard approved these changes

@eigil eigil Awaiting requested review from eigil

@xavi160 xavi160 Awaiting requested review from xavi160

Assignees

@Braggiouy Braggiouy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An Option to Use Native DOM Events Instead of Synthetic Events
4 participants
@Braggiouy @asgvard @xavi160 @predikament