-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC-0001: Propose a format and process for handling RFCs #2
base: main
Are you sure you want to change the base?
Conversation
LGTM, just a smol suggestion: Can we name the RFCs in accordance to their PR number? It centers the RFC identifier around the discussion and gives you an easy way to get back to the original discussion. This means authors will need to create a |
I wondered about the best way to handle the numbering, currently, we could have conflicts on those numbers but with its presumed low usage this would be minimal. I'm not a big fan of having to update the number after pushing the PR. Perhaps we should explore using an issue first, then create a branch from that and finalise an agreement in the PR. GIt history on the RFC file in question will provide the required audit trail. |
Fair enough, let's see how it goes.
I don't like this idea, it splits up the conversation too much and complicates the process. I think it's better to disable issues completely and direct discussion to discord. |
Agreed. Ok, I'll add the example file to the repo too later |
In lieu of commenting on Discord and being berated for it I'll bring my concerns/thoughts here.
|
It's an attempt to catalogue those discussions so they can actually be actioned and collected rather than a conversation on Discord that disappears into the ether.
Currently requires 3 PR approvals, but this could be expanded as more collaboration is received (an RFC will be raised if/when).
Anyone who cares to - I might need to check settings on the repo but that would be the intention.
Not a lot. My time is limited, and I am currently the only committed member of the leadership team. That said, most changes are possible by the larger team. [@]moderators & [@]committee roles have the permissions required to make changes to the server upon merge. |
Nothing stopping you doing that on Discord with threads for each suggestion.
If changes are unlikely to be made without sign up from people to do them, is there any point in having this process? Should that come first? Is there not a programmatic way to manage Discord to lighten the burden on the 'maintainers'? |
Deciding on what changes to make (and documenting them) is orthogonal to making those changes. These are two different problems with two very different solutions. We've talked about ways to automate server changes already (Discord as Code, there's even a terraform provider lol), I imagine this will be one of the first RFCs.
This reads as a little disingenuous. There are many drawbacks to using discord threads to discuss community changes. First and foremost being that the community encompasses more than Discord. Another big one for me is that there is no big way to track the status and history of RFCs in discord, whereas GitHub has this out of the box. There is also lots of prior art around RFC processes run through discord, React and Rust are the most notable ones that come to mind. |
They all serve the same end goal though which is the addition or modification of the community as the whole. The former is essentially pointless without the latter, in much the same way as developing a product is pointless without users using it.
It's not disingenuous. React and Rust are many, many orders of magnitude bigger than Norfolk Developers. There's something to be said about starting out simply and small, and growing into a different platform should the need arise. As of right now, there's only been a few people suggesting a few changes; something which could easily be managed within Discord. Should thousands of suggestions start being raised then I'd agree with you! The same argument around Discord not encompassing the community could be made that the community encompasses more than just GitHub users. This feels like over-engineering if that were a term able to be applied to a community forum. |
Just want to clarify some intentions of the RFC process as I think the core of it is being missed right now: This GitHub repository and process is chiefly about documenting decision making. The process as of this PR is really simple:
Step 2 is intentionally undefined. Discussions can happen in GitHub, Discord, in person, or via carrier pigeon. The important thing is that when consensus is reached this is documented. Also, with Step 1, RFCs are about the "what" is changing and don't focus too much on the "how". Naturally this meta proposal is very much about the how which is kind of unavoidable. I do think we could probably drop the |
If it's to document what IS changing (without the discord around changing it or not) then surely it's just a changelog rather than an RFC? There is no request, it'll have already been agreed on. RFCs to me (especially on GitHub) are where discussions around the item and the implementation are debated. If they're not, then what is the point in the pull request functionality with reviewers and approvers? |
I imagine it will act mostly as a changelog tbh, especially for RFCs that relate to the Discord. But there are a few ways in which being on GitHub benefits the process compared to being inside Discord:
Tbh I think requiring 3 approvers is too much, but I guess it makes sense to have Alex + Shaun + one other committee member? Not sure about what the reasoning is behind that decision tbh but I think discussing it isn't really relevant to this discussion - we can bikeshed it separately. |
No description provided.