Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GHC 9.2 support #36

Closed
wants to merge 6 commits into from
Closed

Add GHC 9.2 support #36

wants to merge 6 commits into from

Conversation

srid
Copy link

@srid srid commented Feb 7, 2022

See #35 for other PRs

NorfairKing
NorfairKing reviewed Feb 8, 2022
View reviewed changes
stack-9.2.1.yaml.lock Outdated Show resolved Hide resolved
@srid srid changed the base branch from master to development February 8, 2022 21:38
@srid srid changed the title WIP: Add GHC 9.2 support Add GHC 9.2 support Feb 8, 2022
@srid srid marked this pull request as ready for review February 8, 2022 21:56
@srid
Copy link
Author

srid commented Feb 8, 2022 •
edited
Loading

@sydtest How do I test this for 8.10 in nix-shell? Currently: stack build in nix-shell is unable to find the compiler:

❯ stack build
WARNING: nix-pre-commit-hooks: git command not found; skipping installation.
I don't know how to install GHC on your system configuration, please install manually

Aside from that (and consolidation of overrides in stack yaml post merge?) this PR should be ready for merge.

EDIT: I can change the resolver in stack.yaml to match the nix compiler; that works.

@srid srid mentioned this pull request Feb 8, 2022
Closed
11 tasks
@NorfairKing
Copy link
Owner

nix-build ci.nix should do it.

@NorfairKing NorfairKing force-pushed the development branch 2 times, most recently from 824fcc5 to aac96e2 Compare April 19, 2022 23:00
This was referenced Apr 26, 2022
Closed
Merged
@NorfairKing
Copy link
Owner

Done as part of #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NorfairKing NorfairKing NorfairKing left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srid @NorfairKing