Add Generic OnPowerUp Get and Set to app #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! I'll have a look and come back to you. This may take few days, as I'm busy with another project right now. The UI looks very good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
GetUI forGeneric Power OnOff ServerSetUI forGeneric Power OnOff Setup ServerGet(initial)Get RestoreSet(initial)Set Acked RestoreThe implementation uses the standard pattern for clients in the app with a
GenericPowerOnOffClientDelegateand xibs for UI.Note: The
publicationMessageComposerof theModelDelegateprotocol is not implemented as this an attempt to enable server testing through the app rather than making the app a completeGenericPowerOnOffClient(the same shortcut exists inSensorClientDelegatewhich was mimicked).