Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.10.4 #441

Merged
merged 19 commits into from
Jun 25, 2021
Merged

Version 4.10.4 #441

merged 19 commits into from
Jun 25, 2021

Conversation

philips77
Copy link
Member

This PR adds the following improvements:

Xcode 13 compatibility issue:

State validation:

Minor enhancements:

Note:

dinesharjani and others added 19 commits June 22, 2021 11:09
In Swift 5.5 Apple changed CBCharacteristic's CBService from being unowned to weak, which breaks the existing code under Xcode 13 whilst at the same time, making said fixes break Xcode 12 due to the change being implemented via Swift versioning. I think this fix should work for both Xcode 13 users downgrading their installed Swift to 5.4 or older as well as the opposite, Xcode 12 users who upgrade their internal Swift version to 5.5 and newer.
Removing unnecessary fields from SecureDFUExecutor
Fix for Xcode 13 Builds but retaining Xcode 12 and older compatibility
…-garbage

Accepting garbage in notifications following valid data
@CLAassistant
Copy link

CLAassistant commented Jun 25, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ philips77
✅ dinesharjani
❌ Nick Kibysh


Nick Kibysh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@philips77 philips77 merged commit 1966ca9 into master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants