-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 4.10.4 #441
Merged
Version 4.10.4 #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Swift 5.5 Apple changed CBCharacteristic's CBService from being unowned to weak, which breaks the existing code under Xcode 13 whilst at the same time, making said fixes break Xcode 12 due to the change being implemented via Swift versioning. I think this fix should work for both Xcode 13 users downgrading their installed Swift to 5.4 or older as well as the opposite, Xcode 12 users who upgrade their internal Swift version to 5.5 and newer.
(I think.)
State validation
Removing unnecessary fields from SecureDFUExecutor
Fix for Xcode 13 Builds but retaining Xcode 12 and older compatibility
…ovements Xcode 13 compat improvements
…-garbage Accepting garbage in notifications following valid data
Nick Kibysh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following improvements:
Xcode 13 compatibility issue:
State validation:
Minor enhancements:
Note: