Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enqueueing request in onDeviceDisconnected causes problems #41

Closed
philips77 opened this issue Nov 5, 2018 · 3 comments
Closed

Enqueueing request in onDeviceDisconnected causes problems #41

philips77 opened this issue Nov 5, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@philips77
Copy link
Member

When a connection is disconnected by remote side (status 8), and the manager calls notifyDeviceDisconnected(), it first calls close(), then onDeviceDisconnected().
If a new connection request was added in onDeviceDisconnected() is will be proceeded immediately, as the mOperationInProgress` flag was cleared.
The new request fail callback would be invoked a moment later with the old's request status (8).

@philips77 philips77 added the bug label Nov 5, 2018
@philips77 philips77 added this to the Version 2.0 milestone Nov 5, 2018
@philips77 philips77 self-assigned this Nov 5, 2018
@philips77
Copy link
Member Author

Found in 2.0-beta7

philips77 added a commit that referenced this issue Nov 5, 2018
@philips77
Copy link
Member Author

Fix released in 2.0-beta9.

@philips77
Copy link
Member Author

This might have broken #25 again. More testing needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant