autoConnect=true attempts to reconnect even after invoking disconnect()

[ghost]

I'm trying to disconnect from a device with a connection attempt in progress, but apparently the disconnect is never executed (I never receive any callback) and the autoConnect=true causes an undesired reconnect attempt

Steps

1. Invoke connect.await() on a switched off device
2. After some seconds, invoke

        disconnect()
                .done { Timber.d("disconnect success") }
                .fail { device, status ->
                    Timber.d("disconnect fail")

                    close()
                }
                .enqueue()

3. After some time, connect.await() throws a RequestFailedException: Request failed with status 133 and immediately attempts to reconnect. None of the disconnect callbacks is invoked

Is this working as intended or is it a bug?

[ghost]

This fixes the issue for now, but it's not pretty

This is a wrapper that holds the BleManager class

public void connect() {
    forceDisconnect.set(false);
    bleManager.setGattCallbacks(this);

    try {
      bleManager.connect(bluetoothDevice).await();
    } catch (RequestFailedException | DeviceDisconnectedException | BluetoothDisabledException e) {
      if (forceDisconnect.get()) {
        bleManager.setGattCallbacks(this);

        bleManager.close();
      }

      e.printStackTrace();
    }
  }

public void disconnect() {
    forceDisconnect.set(true);

    bleManager.disconnectWithoutReconnect();
  }

[philips77]

Hi, I'll look into it. Thanks for the report!

[philips77]

Hi @maragues-kolibree,
I was thinking about what should actually happen in this case.
First of all, the correct way of closing pending connection attempt is by setting a timeout. This may be set wither using enqueue(int) or await(int). The PR makes sure the connection gets cancelled in such case.
Also, the lib won't start another connection if the first one failed dues to a timeout.

[ghost]

If you release a new beta, I can test next Monday

[philips77]

I released beta3.

[philips77]

Fixed in beta4 :)

[ghost]

It's fixed, congrats and thanks!!

It's beta3, not beta4, just to keep track for the future.

[ghost]

After this change, is there a way to invoke connect in a way that it keeps trying to reconnect after an error?

I know we can do it manually, just wondering.