-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LLT-5607] Reduce derp connection failure warning logs #973
Merged
stalowyjez
merged 3 commits into
main
from
LLT-5607-reduce_amount_of_logs_on_failing_derp_connection
Jan 23, 2025
Merged
[LLT-5607] Reduce derp connection failure warning logs #973
stalowyjez
merged 3 commits into
main
from
LLT-5607-reduce_amount_of_logs_on_failing_derp_connection
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stalowyjez
force-pushed
the
LLT-5607-reduce_amount_of_logs_on_failing_derp_connection
branch
from
January 8, 2025 11:50
782ac09
to
58695c4
Compare
stalowyjez
changed the title
[LLT-5607] Reduce derp warning logs test
[LLT-5607] Reduce derp warning logs
Jan 8, 2025
stalowyjez
changed the title
[LLT-5607] Reduce derp warning logs
[LLT-5607] Reduce derp connection failure warning logs
Jan 8, 2025
packgron
reviewed
Jan 20, 2025
packgron
reviewed
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1.0
stalowyjez
force-pushed
the
LLT-5607-reduce_amount_of_logs_on_failing_derp_connection
branch
from
January 22, 2025 14:44
058060e
to
bf6299a
Compare
mathiaspeters
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
stalowyjez
force-pushed
the
LLT-5607-reduce_amount_of_logs_on_failing_derp_connection
branch
from
January 22, 2025 16:40
bf6299a
to
cac810f
Compare
stalowyjez
deleted the
LLT-5607-reduce_amount_of_logs_on_failing_derp_connection
branch
January 23, 2025 09:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Apps are getting too much warnings when connection to Derp server is not available
Solution
Print only these logs which are bringing some new information
☑️ Definition of Done checklist