Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLT-5607] Reduce derp connection failure warning logs #973

Merged

Conversation

stalowyjez
Copy link
Contributor

@stalowyjez stalowyjez commented Nov 21, 2024

Problem

Apps are getting too much warnings when connection to Derp server is not available

Solution

Print only these logs which are bringing some new information

☑️ Definition of Done checklist

  • Commit history is clean (requirements)
  • README.md is updated
  • Functionality is covered by unit or integration tests

@stalowyjez stalowyjez force-pushed the LLT-5607-reduce_amount_of_logs_on_failing_derp_connection branch from 782ac09 to 58695c4 Compare January 8, 2025 11:50
@stalowyjez stalowyjez changed the title [LLT-5607] Reduce derp warning logs test [LLT-5607] Reduce derp warning logs Jan 8, 2025
@stalowyjez stalowyjez changed the title [LLT-5607] Reduce derp warning logs [LLT-5607] Reduce derp connection failure warning logs Jan 8, 2025
@stalowyjez stalowyjez marked this pull request as ready for review January 8, 2025 12:59
@stalowyjez stalowyjez requested a review from a team as a code owner January 8, 2025 12:59
Copy link
Collaborator

@packgron packgron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.0

@stalowyjez stalowyjez force-pushed the LLT-5607-reduce_amount_of_logs_on_failing_derp_connection branch from 058060e to bf6299a Compare January 22, 2025 14:44
Copy link
Contributor

@mathiaspeters mathiaspeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@stalowyjez stalowyjez force-pushed the LLT-5607-reduce_amount_of_logs_on_failing_derp_connection branch from bf6299a to cac810f Compare January 22, 2025 16:40
@stalowyjez stalowyjez merged commit dcfd87c into main Jan 23, 2025
64 checks passed
@stalowyjez stalowyjez deleted the LLT-5607-reduce_amount_of_logs_on_failing_derp_connection branch January 23, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants