LLT-5886: Protected RTT QoS pings #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasz-grz
force-pushed
the
protected_pinger
branch
from
e5ec181 to
64aeacc
Compare
tomasz-grz
force-pushed
the
protected_pinger
branch
from
64aeacc to
117a340
Compare
tomasz-grz
force-pushed
the
protected_pinger
branch
from
117a340 to
66b544c
Compare
tomasz-grz
force-pushed
the
protected_pinger
branch
from
66b544c to
04560c4
Compare
tomasz-grz
force-pushed
the
protected_pinger
branch
from
04560c4 to
9ee5468
Compare
tomasz-grz
force-pushed
the
protected_pinger
branch
from
9ee5468 to
410bc9d
Compare
tomasz-grz
force-pushed
the
protected_pinger
branch
2 times, most recently
from
7312c7f to
24ab2d8
Compare
tomasz-grz
force-pushed
the
protected_pinger
branch
from
24ab2d8 to
0c14764
Compare
Jauler
reviewed
Jan 17, 2025
Jauler
reviewed
Jan 17, 2025
Jauler
reviewed
Jan 17, 2025
tomasz-grz
force-pushed
the
protected_pinger
branch
from
d7451b8 to
8f7fd10
Compare
tomasz-grz
force-pushed
the
protected_pinger
branch
from
8f7fd10 to
ce97ddd
Compare
tomasz-grz
force-pushed
the
protected_pinger
branch
from
ce97ddd to
eda58ee
Compare
There was a problem hiding this comment.
Very nice PR.
I checked out the telio-sockets/protector/* and it doesn't contain the information of what it does except the apple.rs which mentions what it tries to do.
While we're at it, would it be possible to add a brief comment into protector.rs about it's purpose?
Anyway, that's not a blocker :) +1
tomasz-grz
force-pushed
the
protected_pinger
branch
from
eda58ee to
fec01aa
Compare
|
Also added rust docs to the protector module. |
In order to add SocketPool, Pinger had to be broken out of telio-utils because of circular dependencies. LinkDetection had to be also updated to use the new Pinger.
tomasz-grz
force-pushed
the
protected_pinger
branch
from
fec01aa to
fe7235c
Compare
LukasPukenis
approved these changes
Jan 21, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Due to the nature of Apple's NetworkExtension control protocol, packets originating from the NetworkExtension process are routed outside of the tunnel.
Because of this on macOS AppStore and iOS platforms, raw ICMP packets from QoS RTT and Link detection components destined for the tunnel interface, leave the main interface instead.
Solution
Use the
SocketPoolcomponent in order to bind the ping raw socket to the tunnel interface. The Pinger component had to moved into it's own crate in order to avoid circular dependencies between Utils and Sockets.LinkDetection component was also updated to use the new Pinger.
☑️ Definition of Done checklist