Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for changes to oslo aero to bring in noresm2_3_develop changes #8

Conversation

mvertens
Copy link
Contributor

@mvertens mvertens commented Feb 20, 2024

Updates that must accompany changes to oslo_aero

Summary:Updates that must accompany changes to oslo_aero

Branch: this will not be tagged but stay on the noresm branch

Contributors: mvertens

Reviewers: @gold2718

Purpose of changes: updates needed to support changes in oslo_aero PR NorESMhub/OSLO_AERO#13

Github PR URL: #8

Changes made to build system: None

Changes made to the namelist: None

Changes to the defaults for the boundary datasets: None

Substantial timing or memory changes: None

Testing: Verified that the following tests passed:
ERP_Ln9.ne30pg3_ne30pg3_mtn14.NF1850oslo.betzy_intel.cam-outfrq9s

Issues addressed by this PR: #9

@gold2718 gold2718 added this to the NorESM2.5 milestone Feb 20, 2024
@mvertens mvertens added the enhancement New feature or request label Feb 20, 2024
Copy link
Contributor

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, more #ifdef statements bite the dust!

@gold2718 gold2718 merged commit f7cd6c4 into NorESMhub:noresm Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants