render runtime crates from templates dynamically #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OmarTawfik
force-pushed
the
render-runtime-crates-from-templates-dynamically
branch
from
f4fa57c
to
a448767
Compare
OmarTawfik
force-pushed
the
render-runtime-crates-from-templates-dynamically
branch
from
a448767
to
93e7e09
Compare
There was a problem hiding this comment.
#930 removes grammar queries, and hence this file and others like it, completely.
AntonyBlakey
approved these changes
May 14, 2024
This was referenced May 15, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 22, 2024
Part of #638, removes the `codegen_grammar` crate Instead of having the definitions and the parser generation separate, we now co-locate this and provide a parser-specific model (for MVC rendering introduced in #962) for the code generation. This mostly moves code around and documents a bit more what we already have. This is fairly non-controversial and I am for #638 to be incremental, so this is meant to progress the issue rather than fix it in one giant PR to keep up the velocity and land it as soon as possible, accounting for my upcoming move to Hardhat soon. If this generally makes sense, I'd love to have a rubber stamp for it; for now, I'll work on top of this to further migrate off DSLv1 definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #863
ariadnereport, with best-guess source location in the template. A temporary workaround waiting for error locations and IDE diagnostics support Keats/tera#885![allow(dead_code)]and![allow(unused)]everywhere (will follow up on this cleanup separately).