Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct versioning for SourceUnitMember and ContractMember rules #558

Merged

Conversation

OmarTawfik
Copy link
Collaborator

No description provided.

@OmarTawfik OmarTawfik requested a review from a team as a code owner July 28, 2023 09:02
@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2023

🦋 Changeset detected

Latest commit: 9c3a73c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
changelog Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@OmarTawfik OmarTawfik marked this pull request as draft July 28, 2023 09:32
auto-merge was automatically disabled July 28, 2023 09:32

Pull request was converted to draft

@OmarTawfik OmarTawfik changed the title fix grammar to make sure FunctionDefinition is illegal before v0.7.1 correct versioning for SourceUnitMember and ContractMember rules Jul 28, 2023
@OmarTawfik OmarTawfik marked this pull request as ready for review July 28, 2023 11:45
@OmarTawfik OmarTawfik added this pull request to the merge queue Jul 29, 2023
Merged via the queue into NomicFoundation:main with commit 95bbc50 Jul 29, 2023
@OmarTawfik OmarTawfik deleted the fix-function-grammar branch July 29, 2023 06:45
@github-actions github-actions bot mentioned this pull request Jul 29, 2023
github-merge-queue bot pushed a commit that referenced this pull request Aug 2, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @nomicfoundation/[email protected]

### Minor Changes

- [#540](#540)
[`0d04f95`](0d04f95)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Add a Rust
Cursor API and refactor the Rust Visitor API to run on top of it.

- [#540](#540)
[`0d04f95`](0d04f95)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Move Visitor
et al to node:: namespace, which is where Cursor is.

- [#540](#540)
[`0d04f95`](0d04f95)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Rename
`range` functions that return a TextRange to `text_range`

### Patch Changes

- [#543](#543)
[`7a34599`](7a34599)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Move
`syntax::parser::ProductionKind` to `syntax::nodes` namespace.

- [#540](#540)
[`0d04f95`](0d04f95)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Add
TokenNode.text to the TS API.

- [#540](#540)
[`0d04f95`](0d04f95)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Add first
pass of Typescript binding to the Cursor API, but no TS Visitor yet.

- [#545](#545)
[`e73658a`](e73658a)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - render EBNF
grammar on top of each `ProductionKind`, `RuleKind`, and `TokenKind`.

- [#558](#558)
[`95bbc50`](95bbc50)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Correct
versioning for `SourceUnitMember` and `ContractMember` children.

## [email protected]

### Minor Changes

- [#540](#540)
[`0d04f95`](0d04f95)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Add a Rust
Cursor API and refactor the Rust Visitor API to run on top of it.

- [#540](#540)
[`0d04f95`](0d04f95)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Move Visitor
et al to node:: namespace, which is where Cursor is.

- [#540](#540)
[`0d04f95`](0d04f95)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Rename
`range` functions that return a TextRange to `text_range`

### Patch Changes

- [#543](#543)
[`7a34599`](7a34599)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Move
`syntax::parser::ProductionKind` to `syntax::nodes` namespace.

- [#540](#540)
[`0d04f95`](0d04f95)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Add
TokenNode.text to the TS API.

- [#540](#540)
[`0d04f95`](0d04f95)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Add first
pass of Typescript binding to the Cursor API, but no TS Visitor yet.

- [#545](#545)
[`e73658a`](e73658a)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - render EBNF
grammar on top of each `ProductionKind`, `RuleKind`, and `TokenKind`.

- [#558](#558)
[`95bbc50`](95bbc50)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - Correct
versioning for `SourceUnitMember` and `ContractMember` children.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants