Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor - highlight "verify:sourcify" subtask, based on feedback … #4829

Closed
wants to merge 1 commit into from

Conversation

bguiz
Copy link

@bguiz bguiz commented Feb 7, 2024

…from @schaable

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

Copy link

changeset-bot bot commented Feb 7, 2024

⚠️ No Changeset found

Latest commit: d5fb7b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 8:06am

@@ -230,6 +230,16 @@ await hre.run("verify:verify", {

If the verification is not successful, an error will be thrown.

Note that the `"verify:verify"` subtask will *always* run the etherscan verifier, even when you have the following in your hardhat config file:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the last published version of hardhat-verify this would be incorrect, see here. You can verify both providers with the same task, and control which one is executed through the config.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, if so this PR is redundant. Closing!

@bguiz bguiz closed this Feb 8, 2024
@bguiz bguiz deleted the patch-1 branch February 8, 2024 12:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants