Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest version of Hardhat doesn't work with solidity-coverage #4063

Closed
wattsyart opened this issue Jun 22, 2023 · 4 comments · Fixed by thesandboxgame/sandbox-smart-contracts#1015
Closed

Latest version of Hardhat doesn't work with solidity-coverage #4063

wattsyart opened this issue Jun 22, 2023 · 4 comments · Fixed by thesandboxgame/sandbox-smart-contracts#1015
Labels
status:blocked Blocked by other issues or external reasons

Comments

@wattsyart
Copy link

Version of Hardhat

2.16.0

What happened?

Starting a new example JavaScript project results in failed solidity-coverage.

Minimal reproduction steps

  • npx hardhat
  • Create a JavaScript project
  • npm install --save-dev "hardhat@^2.16.0" "@nomicfoundation/hardhat-toolbox@^3.0.0"
  • npx hardhat coverage

"Error in plugin solidity-coverage: TypeError: provider.send is not a function"

Search terms

solidity-coverage TypeError
@Prcentos
Copy link

Yeah, I have encountered the same question

@fvictorio
Copy link
Member

Hi, yes, solidity-coverage relies on some internal APIs that we changed in the latest release.

I sent a PR some weeks ago preparing it for this new version: sc-forks/solidity-coverage#796 But the fix is not published yet.

Sorry about that! Hopefuly @cgewecke releases a new version soon.

@fvictorio fvictorio added status:blocked Blocked by other issues or external reasons and removed status:triaging labels Jun 22, 2023
@fvictorio fvictorio changed the title Latest CLI startup fails solidity-coverage Latest version of Hardhat doesn't work with solidity-coverage Jun 22, 2023
@fvictorio
Copy link
Member

Version 0.8.3 of solidity-coverage should now work with the latest version of Hardhat! Please let me know if it doesn't.

@github-project-automation github-project-automation bot moved this to Done in Hardhat Jun 22, 2023
@Prcentos
Copy link

Version 0.8.3 of solidity-coverage have resolve this problem

adjisb added a commit to thesandboxgame/sandbox-smart-contracts that referenced this issue Jun 27, 2023
@adjisb
fix: update solidity-coverage on core package
ea3b713 
To fix: NomicFoundation/hardhat#4063
@adjisb adjisb mentioned this issue Jun 27, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status:blocked Blocked by other issues or external reasons
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update solidity-coverage on core package thesandboxgame/sandbox-smart-contracts
3 participants
@fvictorio @Prcentos @wattsyart