feat: add intialize and finalize for AstAnalyser.analyze API #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tony Gorez <[email protected]>
|
All tests should failed, I'd like to confirm that we are okay with the API first. |
tony-go
requested review from
fraxken,
PierreDemailly and
a team
and removed request for
fraxken
tony-go
commented
May 15, 2024
Signed-off-by: Tony Gorez <[email protected]>
tony-go
force-pushed
the
ast-analyser-init-fin
branch
from
6be439d
to
d610873
Compare
|
Note: we need the same for analyseFile (it use analyse but interfaces/options should be the same) |
Signed-off-by: Tony Gorez <[email protected]>
Signed-off-by: Tony Gorez <[email protected]>
+ reorder tests Signed-off-by: Tony Gorez <[email protected]>
|
Hey @fraxken could you PTAL?
Lets do it into a subsequent PR, if you don't mind. |
fraxken
approved these changes
May 16, 2024
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #268
Signed-off-by: Tony Gorez [email protected]