-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(unsafe-import): warning on unsafe-import using eval/require #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraxken
requested changes
Dec 18, 2023
fraxken
reviewed
Dec 19, 2023
fraxken
reviewed
Dec 31, 2023
fraxken
requested changes
Jan 6, 2024
fraxken
approved these changes
Jan 7, 2024
fraxken
reviewed
Jan 8, 2024
I have updated the PR according to your comments, again thanks a lot lot for your help and your time, I couldn't have done it without your help ! 😄 |
fraxken
approved these changes
Jan 8, 2024
This was referenced Jun 5, 2024
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #179
Warning on unsafe-import using eval/require
const stream = eval('require')('stream')
Purpose of this PR is to propose a fix for the issue #179 by mdofifying probes isRequire & isUnsafeCallee :
Feel free to update it or give any feedback i'll be happy to try to improve it (this is my first real PR 😄 i'm new to the environment so I didn't dig deeper yet sorry, but don't hesitate to give any suggestion to improve it)
Result after :