Skip to content

Commit

Permalink
Lower logging verbosity from error to warn
Browse files Browse the repository at this point in the history
* there's nothing we can do about these exceptions, anyways, and they are treated as graceful as possible, so `error` doesn't make sense
* shorten log output and remove stacktrace
* closes #38
  • Loading branch information
qqilihq committed Mar 18, 2024
1 parent f18421b commit 4e34ab1
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ private static boolean isStreamable(NodeModel nodeModel) {
}
} catch (NoSuchMethodException e) {
// this should never happen, as the method is implemented by the NodeModel class
LOGGER.error(String.format("No createStreamableOperator method in %s", nodeModel.getClass().getName()), e);
LOGGER.warn(String.format("No createStreamableOperator method in %s", nodeModel.getClass().getName()));
}
return false;
}
Expand All @@ -673,7 +673,7 @@ private static Optional<String> getBundleName(NodeFactory<?> nodeFactory) {
method.setAccessible(true);
return (Optional<String>) method.invoke(nodeFactory);
} catch (ReflectiveOperationException | IllegalArgumentException e) {
LOGGER.error(String.format("Could not call getBundleName for %s", nodeFactory.getClass().getName()), e);
LOGGER.warn(String.format("Could not call getBundleName for %s: %s", nodeFactory.getClass().getName(), e.getMessage()));
return Optional.empty();
}
}
Expand Down

0 comments on commit 4e34ab1

Please sign in to comment.