Use rel=me for links in user profile
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`noreferrer` already implies `noopener`
3 tasks
|
Excellent thank you 😄 |
|
Can you also add this for Persona in |
oplik0
added a commit
to oplik0/nodebb-theme-persona
that referenced
this pull request
Aug 8, 2023
oplik0
added a commit
to oplik0/nodebb-theme-persona
that referenced
this pull request
Aug 8, 2023
This was referenced Aug 8, 2023
Merged
julianlam
pushed a commit
to NodeBB/nodebb-theme-persona
that referenced
this pull request
Aug 8, 2023
julianlam
pushed a commit
to NodeBB/nodebb-theme-persona
that referenced
this pull request
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the first part of NodeBB/NodeBB#11886
Additionally, I removed the redundant
noopenerfrom the link - AFAIK all browsers that support it, supportnoreferrerimplying the same behavior in addition to not passing theRefererheader (sincenoreferreris older)Edit: turns out using both can actually cause some older browsers to NOT respect
noreferrer(specifically, Firefox between version 33-35): jsx-eslint/eslint-plugin-react#2022 (comment)