Prevent unsanitized queries from creating Cloudflare errors #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This actually has been a bug for a long time, but I haven't noticed this. Within the dictionary commands, you can send an invalid query (e.g. for SQL injection), and Cloudflare would block it. This would result in a content type being HTML, and a HTTP 403 status code would be sent from Discord. There were some folks who abused this to try and get Catherine-Chan to crash thinking that error handling was not implemented and an attempt to block the event loop (which never happened as Catherine-Chan uses aiohttp for HTTP requests, not the
requests
library)Types of changes
What types of changes does your code introduce to Catherine-Chan
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply