Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Dictionary module #221

Merged
merged 20 commits into from
Oct 27, 2024
Merged

Rewrite Dictionary module #221

merged 20 commits into from
Oct 27, 2024

Conversation

No767
Copy link
Owner

@No767 No767 commented Oct 27, 2024

Summary

Caution

This PR entirely removes the /dictionary lookup command due to its internal API route being broken

This PR entirely rewrites the dictionary cog from the ground up. There have been a lot of changes, including the removal of the /dictionary lookup command as the internal API route is entirely broken. The dictionary commands are now rewritten for much faster performance, and have seen an performance increase of nearly 2x compared to the original code. All of the utility functions used in the commands are now thoroughly unit tested to ensure that all edge cases have been met, and generally provides a much cleaner, and better user experience.

This is the last module to undergo the rewrite for Catherine-Chan

Types of changes

What types of changes does your code introduce to Catherine-Chan
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (Updates to README.md, the documentation, etc)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes. (if appropriate)
  • All workflows (except pre-commit.ci) pass with my new changes
  • This PR does not address a duplicate issue or PR

bot/cogs/dictionary.py Fixed Show fixed Hide fixed
bot/cogs/dictionary.py Fixed Show fixed Hide fixed
Copy link

sonarcloud bot commented Oct 27, 2024

@No767 No767 merged commit 035d1ac into main Oct 27, 2024
12 checks passed
@No767 No767 deleted the noelle/dict-rewrite branch October 27, 2024 22:14
@No767 No767 mentioned this pull request Oct 27, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant