-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Dictionary module #221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the lookup command has to be removed as the internal system behind it is broken as of now
Quality Gate passedIssues Measures |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Caution
This PR entirely removes the
/dictionary lookup
command due to its internal API route being brokenThis PR entirely rewrites the dictionary cog from the ground up. There have been a lot of changes, including the removal of the
/dictionary lookup
command as the internal API route is entirely broken. The dictionary commands are now rewritten for much faster performance, and have seen an performance increase of nearly 2x compared to the original code. All of the utility functions used in the commands are now thoroughly unit tested to ensure that all edge cases have been met, and generally provides a much cleaner, and better user experience.This is the last module to undergo the rewrite for Catherine-Chan
Types of changes
What types of changes does your code introduce to Catherine-Chan
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply