-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite foundations of unit tests #189
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since the beginning of Catherine-Chan, unit tests have been an part of the codebase. These unit tests weren't written properly as I was still learning the ropes of pytest and unit testing in general. These tests over time broke, and with the release of pytest 8, entirely broken all unit tests that I had written. Instead of looking at code coverage, this time around, unit tests are being rewritten. This time around, I've included
tox
to handle running them, and settings are passed inpyproject.toml
. In short, this time, unit tests are being done properly and with one step at a time, we are able to make Catherine-Chan much better than before.Changes had to be made in order to work with the github actions workflow. This means that when it comes to loading with the configuration, the migrations and unit tests will first try and locate the uri using the
config.yml
configuration, but will fallback to loading from an environment variable (POSTGRES_URI
). This environment variable is passed into tox so things won't break.As another note, all of the old unit tests are now located in the
old_tests
folder in the root directory of the repo.Types of changes
What types of changes does your code introduce to Catherine-Chan
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply