Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entirely remove tonetags #183

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Entirely remove tonetags #183

merged 4 commits into from
Aug 28, 2024

Conversation

No767
Copy link
Owner

@No767 No767 commented Jun 24, 2024

Summary

This PR aims to entirely remove the tonetags feature from Catherine-Chan. An new feature will be brought in soon to replace this old feature.

The rationale behind the removal is pretty simple: it's basically used by no one. With 4 months worth of metrics collection, no one had ever used that feature seriously. There was only one tonetag entry on the production database, and that was something that I myself created. Knowing this, the demand is on the pride profiles and pronouns.page features mostly. So with all due respect, I'm making the decision to remove this feature entirely (and this will be pushed to production at some point)

Caution

This change has been thought of, and from what I can tell, literally NO ONE uses this feature. There is no plan to bring this feature back

Types of changes

What types of changes does your code introduce to Catherine-Chan
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (Updates to README.md, the documentation, etc)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes. (if appropriate)
  • All workflows (except pre-commit.ci) pass with my new changes
  • This PR does not address a duplicate issue or PR

Copy link

sonarcloud bot commented Jun 24, 2024

Copy link

sonarcloud bot commented Aug 27, 2024

@No767 No767 marked this pull request as ready for review August 27, 2024 05:26
@No767 No767 changed the title Remove tonetags Entirely remove tonetags Aug 28, 2024
@No767 No767 merged commit 852f190 into main Aug 28, 2024
13 checks passed
@No767 No767 deleted the noelle/remove-tonetags branch August 28, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant