Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade database migrations #180

Merged
merged 17 commits into from
Jun 22, 2024
Merged

Upgrade database migrations #180

merged 17 commits into from
Jun 22, 2024

Conversation

No767
Copy link
Owner

@No767 No767 commented Jun 20, 2024

Summary

This PR focuses on completely rewriting the database migrations to an newer home-grown system. This system will possibly break the existing migrations and data, so this PR is reviewed very heavily.

The rationale here is to centralize all migrations code to an home-grown solution as asyncpg-trek has many issues that made it harder to detect and identify files for particular features. This new system is based off of R. Danny's migrations runner.

Caution

This PR may break the internal code of Catherine-Chan

Types of changes

What types of changes does your code introduce to Catherine-Chan
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (Updates to README.md, the documentation, etc)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes. (if appropriate)
  • All workflows (except pre-commit.ci) pass with my new changes
  • This PR does not address a duplicate issue or PR

@No767 No767 marked this pull request as ready for review June 20, 2024 05:00
Copy link

sonarcloud bot commented Jun 22, 2024

@No767 No767 merged commit 7181025 into main Jun 22, 2024
9 checks passed
@No767 No767 deleted the noelle/migrations branch June 22, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant