Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Prometheus metrics #178

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Rewrite Prometheus metrics #178

merged 4 commits into from
Jun 13, 2024

Conversation

No767
Copy link
Owner

@No767 No767 commented Jun 12, 2024

Summary

This PR focuses on completely rewriting the Prometheus metrics to collect data in an more stable and improved method. The collectors are now split up, making it easier to debug and manage. In addition, an new metric, discord_commands_count, which has an label to count each individual command, is added. This makes it much easier to find what commands are used the most and to make an informed decision on it.

This PR breaks the entire Grafana dashboard associated with these metrics

Types of changes

What types of changes does your code introduce to Catherine-Chan
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (Updates to README.md, the documentation, etc)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes. (if appropriate)
  • All workflows (except pre-commit.ci) pass with my new changes
  • This PR does not address a duplicate issue or PR

@No767 No767 changed the title Rewrite metrics collection Rewrite metrics Jun 12, 2024
@No767 No767 changed the title Rewrite metrics Rewrite Prometheus metrics Jun 12, 2024
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@No767 No767 marked this pull request as ready for review June 13, 2024 02:30
@No767 No767 merged commit 98d6700 into main Jun 13, 2024
9 checks passed
@No767 No767 deleted the noelle/better-metrics branch June 13, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant