Skip to content

Commit

Permalink
disable fuse.shared.caching.reader.enabled for alluxio and goosefs, see
Browse files Browse the repository at this point in the history
Alluxio/alluxio#14909

Signed-off-by: nizifan <[email protected]>
  • Loading branch information
nizifan committed Jan 26, 2022
1 parent b947121 commit ce269f2
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion pkg/ddc/alluxio/port_parser_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ properties:
alluxio.fuse.debug.enabled: "false"
alluxio.fuse.jnifuse.enabled: "true"
alluxio.fuse.logging.threshold: 1000ms
alluxio.fuse.shared.caching.reader.enabled: "true"
alluxio.fuse.user.group.translation.enabled: "true"
alluxio.job.master.finished.job.retention.time: 30sec
alluxio.job.master.rpc.port: "20004"
Expand Down
3 changes: 2 additions & 1 deletion pkg/ddc/alluxio/transform_optimization.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ func (e *AlluxioEngine) optimizeDefaultProperties(runtime *datav1alpha1.AlluxioR
setDefaultProperties(runtime, value, "alluxio.fuse.logging.threshold", "1000ms")
setDefaultProperties(runtime, value, "alluxio.worker.block.master.client.pool.size", "1024")
// Add the optimization of the same blocks concurrent access from https://github.com/Alluxio/alluxio/pull/12453 which is from Microsoft
setDefaultProperties(runtime, value, "alluxio.fuse.shared.caching.reader.enabled", "true")
// Disable this optimization since it will cause availbilty issue. see https://github.com/Alluxio/alluxio/issues/14909
// setDefaultProperties(runtime, value, "alluxio.fuse.shared.caching.reader.enabled", "true")
// job retention time only kicks in when the JobMaster is at capacity in terms of number of jobs stored. see https://github.com/Alluxio/alluxio/pull/12468
setDefaultProperties(runtime, value, "alluxio.job.master.finished.job.retention.time", "30sec")
// fixed with https://github.com/Alluxio/alluxio/issues/11437
Expand Down
1 change: 0 additions & 1 deletion pkg/ddc/goosefs/port_parser_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ properties:
goosefs.fuse.debug.enabled: "false"
goosefs.fuse.jnifuse.enabled: "true"
goosefs.fuse.logging.threshold: 1000ms
goosefs.fuse.shared.caching.reader.enabled: "true"
goosefs.fuse.user.group.translation.enabled: "true"
goosefs.job.master.finished.job.retention.time: 30sec
goosefs.job.master.rpc.port: "20004"
Expand Down
1 change: 0 additions & 1 deletion pkg/ddc/goosefs/shutdown_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ properties:
goosefs.fuse.debug.enabled: "true"
goosefs.fuse.jnifuse.enabled: "true"
goosefs.fuse.logging.threshold: 1000ms
goosefs.fuse.shared.caching.reader.enabled: "true"
goosefs.fuse.user.group.translation.enabled: "true"
goosefs.job.master.finished.job.retention.time: 30sec
goosefs.job.master.rpc.port: "28362"
Expand Down
3 changes: 2 additions & 1 deletion pkg/ddc/goosefs/transform_optimization.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ func (e *GooseFSEngine) optimizeDefaultProperties(runtime *datav1alpha1.GooseFSR
setDefaultProperties(runtime, value, "goosefs.user.logging.threshold", "1000ms")
setDefaultProperties(runtime, value, "goosefs.fuse.logging.threshold", "1000ms")
setDefaultProperties(runtime, value, "goosefs.worker.block.master.client.pool.size", "1024")
setDefaultProperties(runtime, value, "goosefs.fuse.shared.caching.reader.enabled", "true")
// Disable this optimization since it will cause availbilty issue. see https://github.com/Alluxio/alluxio/issues/14909
// setDefaultProperties(runtime, value, "goosefs.fuse.shared.caching.reader.enabled", "true")
setDefaultProperties(runtime, value, "goosefs.job.master.finished.job.retention.time", "30sec")
setDefaultProperties(runtime, value, "goosefs.underfs.object.store.breadcrumbs.enabled", "false")

Expand Down

0 comments on commit ce269f2

Please sign in to comment.