[DOC] - Reduce code blocks in capabilties #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:
Experiment 2: air-passengersDescription:
Results:
Plot:
Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot:
|
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:
Experiment 2: air-passengersDescription:
Results:
Plot:
Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot:
|
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:
Experiment 2: air-passengersDescription:
Results:
Plot:
Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot:
|
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:
Experiment 2: air-passengersDescription:
Results:
Plot:
Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot:
|
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:
Experiment 2: air-passengersDescription:
Results:
Plot:
Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot:
|
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:
Experiment 2: air-passengersDescription:
Results:
Plot:
Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot:
|
AzulGarza
reviewed
May 8, 2024
| @@ -11,7 +11,7 @@ | |||
| "cell_type": "markdown", | |||
There was a problem hiding this comment.
let's make sure all the nbs have similar headers, to maintain the same across nbs, eg
nbs/docs/capabilities/anomaly-detection/04_confidence_levels.ipynb does not have the initial text as header.
Reply via ReviewNB
There was a problem hiding this comment.
Hello Azul! I don't know why in reviewNB the little text blurb is shown as a header. In the code, you see that it's just simple markdown with no "#". So, right now, all notebooks are consistent, in the sense that we have the header in the first cell, then we have a little blurb as normal text in the second cell. Not sure why it appears like this here. I'll rerun everything. It should look like in nbs/docs/capabilities/anomaly-detection/04_confidence_levels.ipynb
nbs/docs/capabilities/anomaly-detection/03_anomaly_detection_date_features.ipynb
Outdated
Show resolved
Hide resolved
| @@ -11,7 +11,11 @@ | |||
| "cell_type": "markdown", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
No, just a little blurb to guide the users. The idea was to remove headers so that I could combine code blocks together and have less code blocks to copy/paste, as Max suggested.
| @@ -11,7 +11,14 @@ | |||
| "cell_type": "markdown", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
My plan was to keep it as a normal text. I will fix the other notebooks that show headers instead.
AzulGarza
requested changes
May 8, 2024
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:
Experiment 2: air-passengersDescription:
Results:
Plot:
Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot:
|
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:
Experiment 2: air-passengersDescription:
Results:
Plot:
Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot:
|
AzulGarza
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Less code blocks in capabilities notebooks
Includes links to more detailed tutorials in the docu.
Number of code blocks cannot be reduced further because the CI blocks code cells with imports and code within the same cell.
Add a detailed tutorial on anomaly detection. Tutorial is compatible with Google Colab.