-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/kan experiment #999
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very cool @marcopeix, i left a couple of comments. also i think it might be pretty awesome to release the Auto
version as well. perhaps in a different pr, once this one is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
- I think we should also add an
AutoKANLinear
model inmodels.ipynb
, I think users will like the ability to have it auto-optimize when they are playing with the architecture. You can just copy-paste most of the code from a comparable MLP-based architecture and change the names. - I think
KANLinear
should also be added tomodels.py
andevaluation.py
in action_files/test_models/src
@marcopeix we also need to add KAN to the evaluation pipeline in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @marcopeix!
@cchallu I already added KAN to the evaluation pipeline in action_files. Olivier checked it and says it's good! Let me know if I am missing something! |
This PR is getting pretty big. Is it possible to review it and merge it soon? @cchallu @AzulGarza. Thanks! 😄 |
@marcopeix Convolutional KAN could also be considered, see: https://github.com/IvanDrokin/torch-conv-kan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Maybe also here we need to clear the outputs of the notebook of the models.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
* fix_docs * add_timemixer_to_overview
Changes have already been addressed, PR can be merged
Add KAN model
Benchmark of KAN on M3 and M4 dataset against MLP and NBEATS