copy config in optuna (#844)

Nixtla · Jan 9, 2024 · 714c036 · 714c036
1 parent 3113a20
commit 714c036
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/nbs/common.base_auto.ipynb b/nbs/common.base_auto.ipynb
@@ -342,15 +342,16 @@
     "        import optuna\n",
     "\n",
     "        def objective(trial):\n",
-    "            cfg = config(trial)\n",
+    "            user_cfg = config(trial)\n",
+    "            cfg = deepcopy(user_cfg)\n",
     "            fitted_model = self._fit_model(\n",
     "                cls_model=cls_model,\n",
     "                config=cfg,\n",
     "                dataset=dataset,\n",
     "                val_size=val_size,\n",
     "                test_size=test_size,\n",
     "            )\n",
-    "            trial.set_user_attr('ALL_PARAMS', cfg)\n",
+    "            trial.set_user_attr('ALL_PARAMS', user_cfg)\n",
     "            metrics = fitted_model.trainer.callback_metrics\n",
     "            trial.set_user_attr('METRICS', {\n",
     "                \"loss\": metrics[\"ptl/val_loss\"],\n",

diff --git a/neuralforecast/common/_base_auto.py b/neuralforecast/common/_base_auto.py
@@ -307,15 +307,16 @@ def _optuna_tune_model(
         import optuna
 
         def objective(trial):
-            cfg = config(trial)
+            user_cfg = config(trial)
+            cfg = deepcopy(user_cfg)
             fitted_model = self._fit_model(
                 cls_model=cls_model,
                 config=cfg,
                 dataset=dataset,
                 val_size=val_size,
                 test_size=test_size,
             )
-            trial.set_user_attr("ALL_PARAMS", cfg)
+            trial.set_user_attr("ALL_PARAMS", user_cfg)
             metrics = fitted_model.trainer.callback_metrics
             trial.set_user_attr(
                 "METRICS",