Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernizations and strictness improvements #464

Merged
merged 17 commits into from
Feb 21, 2023
Merged

Modernizations and strictness improvements #464

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ce5907f
Add required includes in header file
cgzones Feb 21, 2023
fbb12a7
Add misc functions annotations
cgzones Feb 21, 2023
09673eb
Drop unnecessary friend declarations
cgzones Feb 21, 2023
404761c
Use C++ casts instead of raw C ones in hdr()
cgzones Feb 21, 2023
a393454
Avoid unnecessary copies in splitColonDelimitedString()
cgzones Feb 21, 2023
c00676a
Close file before potentially throwing
cgzones Feb 21, 2023
98d1813
Drop unnecessary casts in getElfType()
cgzones Feb 21, 2023
e883229
Avoid potential overflows in checkPointer()
cgzones Feb 21, 2023
b2897ab
Use C++11 [[noreturn]]
cgzones Feb 21, 2023
1c2d1ff
Drop superfluous semicolons
cgzones Feb 21, 2023
889350d
Declare file local functions static
cgzones Feb 21, 2023
b5b59ca
Avoid dropping const qualifier
cgzones Feb 21, 2023
959cd16
Enable Wextra
cgzones Feb 21, 2023
28e95b3
Avoid implicit value truncations in wri()
cgzones Feb 21, 2023
00d1e82
Avoid implicit conversion
cgzones Feb 21, 2023
81c64dd
Declare more read-only functions const
cgzones Feb 21, 2023
ff7a5be
Avoid memory corruption on invalid ELF input
cgzones Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/patchelf.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,11 +196,11 @@ static FileContents readFile(const std::string & fileName,
while ((portion = read(fd, contents->data() + bytesRead, size - bytesRead)) > 0)
bytesRead += portion;

close(fd);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be even autoclosed later on.


if (bytesRead != size)
throw SysError(fmt("reading '", fileName, "'"));

close(fd);

return contents;
}

Expand Down