-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux_zen: 5.8.1 -> 5.8.7 #97038
linux_zen: 5.8.1 -> 5.8.7 #97038
Conversation
Result of 35 packages failed to build:- linuxPackages_zen.amdgpu-pro - linuxPackages_zen.anbox - linuxPackages_zen.ati_drivers_x11 - linuxPackages_zen.batman_adv - linuxPackages_zen.can-isotp - linuxPackages_zen.chipsec - linuxPackages_zen.cryptodev - linuxPackages_zen.ena - linuxPackages_zen.exfat-nofuse - linuxPackages_zen.ixgbevf - linuxPackages_zen.lttng-modules - linuxPackages_zen.mwprocapture - linuxPackages_zen.mxu11x0 - linuxPackages_zen.ndiswrapper - linuxPackages_zen.netatop - linuxPackages_zen.nvidia_x11_legacy304 - linuxPackages_zen.nvidia_x11_legacy340 - linuxPackages_zen.nvidia_x11_legacy390 - linuxPackages_zen.nvidiabl - linuxPackages_zen.openafs - linuxPackages_zen.openafs_1_8 - linuxPackages_zen.phc-intel - linuxPackages_zen.r8168 - linuxPackages_zen.rtl8723bs - linuxPackages_zen.rtl8812au - linuxPackages_zen.rtl8814au - linuxPackages_zen.rtl8821au - linuxPackages_zen.rtl8821cu - linuxPackages_zen.rtl88x2bu - linuxPackages_zen.rtl88xxau-aircrack - linuxPackages_zen.rtlwifi_new - linuxPackages_zen.sch_cake - linuxPackages_zen.tbs - linuxPackages_zen.virtualbox - linuxPackages_zen.virtualboxGuestAdditions 42 packages built:- linuxPackages_zen.acpi_call - linuxPackages_zen.asus-wmi-sensors - linuxPackages_zen.bbswitch - linuxPackages_zen.bcc - linuxPackages_zen.bpftrace - linuxPackages_zen.broadcom_sta - linuxPackages_zen.cpupower - linuxPackages_zen.ddcci-driver - linuxPackages_zen.digimend - linuxPackages_zen.dpdk - linuxPackages_zen.evdi - linuxPackages_zen.facetimehd - linuxPackages_zen.fwts-efi-runtime - linuxPackages_zen.hyperv-daemons - linuxPackages_zen.intel-speed-select - linuxPackages_zen.it87 - linuxPackages_zen.jool - linuxPackages_zen.kernel - linuxPackages_zen.mba6x_bl - linuxPackages_zen.nvidia_x11 - linuxPackages_zen.oci-seccomp-bpf-hook - linuxPackages_zen.openrazer - linuxPackages_zen.perf - linuxPackages_zen.ply - linuxPackages_zen.r8125 - linuxPackages_zen.rtl8192eu - linuxPackages_zen.rtl8821ce - linuxPackages_zen.sysdig - linuxPackages_zen.systemtap - linuxPackages_zen.tmon - linuxPackages_zen.tp_smapi - linuxPackages_zen.turbostat - linuxPackages_zen.tuxedo-keyboard - linuxPackages_zen.usbip - linuxPackages_zen.v4l2loopback - linuxPackages_zen.v86d - linuxPackages_zen.vhba - linuxPackages_zen.x86_energy_perf_policy - linuxPackages_zen.xpadneo - linuxPackages_zen.zenpower - linuxPackages_zen.zfs - linuxPackages_zen.zfsUnstable |
6240959
to
a133475
Compare
If you have a build setup where review builds make sense, could you check that the failures are already present before the bump? |
Is there a trivial way of doing that? The build failures all sound like out-of-tree modules that I wouldn't expect to be compatible with 5.8 yet though. (The popular ones (ZFS and Nvidia) both work however). Perhaps we should declare which ABIs each module are compatible with so that nobody even attempts to build them for incompatible kernels. |
Is there a trivial way of doing that?
Hmm. A more efficient way is to take the list, replace the start-of-line with «nix-build --no-out-link '<nixpkgs>' -A », the end-of-line with « >> /tmp/zen-paths.log» and see if there is any output file in the log.
A more tooling-friendly is probably nix-reviewing a change that sets preUnpack to «true».
The build failures all sound like out-of-tree modules that I wouldn't expect to be compatible with 5.8 yet though. (The popular ones (ZFS and Nvidia) both work however).
Ah, makes sense
Perhaps we should declare which ABIs each module are compatible with so that nobody even attempts to build them for incompatible kernels.
Well, you often do not know in advance if the next release will contain breaking API changes for free but out-of-tree modules.
|
I couldn't get anything decent working ad-hoc but I think most of these were broken before too. Mic92/nixpkgs-review#85 should cover this use-case though.
I meant a blocklist that gets amended when a new ABI becomes incompatible. E.g. no longer works on 5.8 -> mark as broken for >=5.8. Though it seems like many of the packages were already marked as broken. Not sure why nixpkgs-review tried to build them and reported them as failures when they were known to be bad before and after. |
Motivation for this change
Closes #96933
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)