Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agda: add release notes #95894

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Agda: add release notes #95894

merged 1 commit into from
Sep 1, 2020

Conversation

alexarice
Copy link
Contributor

Motivation for this change

#95765

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I have tried to build the docs locally and I think it worked though it seemed to reformat a lot of files. I am not sure if what I have done is the best way to cross reference the nixpkgs manual

@jonringer

@alexarice alexarice force-pushed the agda-release-notes branch 4 times, most recently from 47be3e1 to 5b77174 Compare August 21, 2020 08:14
jonringer
jonringer reviewed Aug 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM, but I'm not great at docbook, I'll let sometime for others to commentate

jonringer
jonringer approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant to approve

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 21, 2020
Ma27
Ma27 reviewed Aug 22, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is not that easy to read. You probably want to list all the changes that happened as <itemizedlist> in this entry.

nixos/doc/manual/release-notes/rl-2009.xml Outdated Show resolved Hide resolved
@veprbl veprbl added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 23, 2020
@alexarice
Copy link
Contributor Author

Have split this into a list and rebased

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 23, 2020
@roberth roberth merged commit c914fff into NixOS:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 left review comments

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexarice @Ma27 @jonringer @veprbl @roberth