Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ft2-clone: add a test #94187

Merged
merged 2 commits into from
Oct 12, 2020
Merged

ft2-clone: add a test #94187

merged 2 commits into from
Oct 12, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jul 29, 2020

Motivation for this change

New release, and a test because why not

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fgaz fgaz force-pushed the ft2-clone/1.27 branch from fc0898c to 5a7a029 Compare July 29, 2020 17:46
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 29, 2020
@fgaz fgaz mentioned this pull request Jul 29, 2020
Merged
10 tasks
@fgaz
Copy link
Member Author

fgaz commented Aug 13, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 13, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2 needs_reviewer (old Marvin label, do not use) labels Aug 13, 2020
@symphorien
Copy link
Member

There is a merge conflict
/status awaiting_changes

@marvin-mk2 marvin-mk2 bot added awaiting_changes (old Marvin label, do not use) and removed needs_reviewer (old Marvin label, do not use) labels Aug 29, 2020
@marvin-mk2 marvin-mk2 bot added awaiting_reviewer (old Marvin label, do not use) and removed awaiting_changes (old Marvin label, do not use) labels Sep 7, 2020
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Sep 7, 2020
@fgaz fgaz changed the title ft2-clone: 1.26 -> 1.27, add a test ft2-clone: add a test Sep 7, 2020
fgaz added 2 commits September 7, 2020 11:21
@fgaz
ft2-clone: add nixos test
e158d19
@fgaz
ft2-clone: fix some darwin dependencies
75414df 
Still failing, but it goes further than before
@fgaz
Copy link
Member Author

fgaz commented Sep 8, 2020

@symphorien fixed

@marvin-mk2 marvin-mk2 bot added needs_reviewer (old Marvin label, do not use) and removed awaiting_reviewer (old Marvin label, do not use) labels Sep 11, 2020
@marvin-mk2 marvin-mk2 bot requested a review from timokau October 10, 2020 20:30
@marvin-mk2 marvin-mk2 bot removed the needs_reviewer (old Marvin label, do not use) label Oct 10, 2020
@marvin-mk2 marvin-mk2 bot added the awaiting_reviewer (old Marvin label, do not use) label Oct 10, 2020
timokau
timokau approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

nixos/tests/ft2-clone.nix Show resolved Hide resolved
@timokau timokau merged commit 787ec15 into NixOS:master Oct 12, 2020
@fgaz fgaz deleted the ft2-clone/1.27 branch October 13, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes awaiting_reviewer (old Marvin label, do not use) marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgaz @symphorien @timokau