Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awscli2: init at 2.0.26 #91655

Merged
merged 1 commit into from
Jul 3, 2020
Merged

awscli2: init at 2.0.26 #91655

merged 1 commit into from
Jul 3, 2020

Conversation

davegallant
Copy link
Member

@davegallant davegallant commented Jun 27, 2020 •
edited
Loading

Motivation for this change

"AWS CLI v2 supports configuring and using credentials through AWS SSO using the new aws configure sso command."
https://aws.amazon.com/blogs/developer/aws-cli-v2-is-now-generally-available/

Since AWS CLI version 1 will be supported for a while, it may make sense to keep this a separate derivation.

#80956

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

bhipple
bhipple requested changes Jun 27, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

pkgs/tools/admin/awscli2/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/awscli2/default.nix Show resolved Hide resolved
pkgs/tools/admin/awscli2/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/awscli2/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from bhipple June 27, 2020 19:19
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Jun 27, 2020
@bhipple
Copy link
Contributor

bhipple commented Jun 30, 2020

LGTM; can you fixup git history per https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md ?

@davegallant davegallant changed the title Add AWS CLI version 2 (2.0.26) aws2: init at 2.0.26 Jul 1, 2020
@davegallant
Copy link
Member Author

LGTM; can you fixup git history per https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md ?

@bhipple Fixed 🔧

@davegallant davegallant changed the title aws2: init at 2.0.26 awscli2: init at 2.0.26 Jul 1, 2020
@bhipple
Copy link
Contributor

bhipple commented Jul 3, 2020

Result of nixpkgs-review pr 91655 1

1 package built:
- awscli2

@bhipple bhipple merged commit f7c7509 into NixOS:master Jul 3, 2020
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
@seh seh mentioned this pull request Mar 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davegallant @bhipple @Janik-Haag