Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spigot: init at 20200101 #90061

Merged
merged 2 commits into from
Jul 15, 2020
Merged

spigot: init at 20200101 #90061

merged 2 commits into from
Jul 15, 2020

Conversation

mcbeth
Copy link
Contributor

@mcbeth mcbeth commented Jun 10, 2020

Spigot is a streaming command-line calculator by Simon Tatham

Motivation for this change

I had a need for this tool, I'm aspiring to move to NixOS, so I added the tool.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 10, 2020
@mcbeth mcbeth changed the title add spigot spigot: init at 20200101 Jun 10, 2020
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 10, 2020
@mcbeth
Copy link
Contributor Author

mcbeth commented Jul 13, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2 label Jul 13, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 13, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the needs_reviewer (old Marvin label, do not use) label Jul 13, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 14, 2020

@turion please review.

@marvin-mk2 marvin-mk2 bot added awaiting_reviewer (old Marvin label, do not use) and removed needs_reviewer (old Marvin label, do not use) labels Jul 14, 2020
@turion
Copy link
Contributor

turion commented Jul 14, 2020

Perfect. It builds. It calculates. Man pages come up.

/status needs_merger

@marvin-mk2 marvin-mk2 bot added needs_merger (old Marvin label, do not use) and removed awaiting_reviewer (old Marvin label, do not use) labels Jul 14, 2020
@marvin-mk2 marvin-mk2 bot requested a review from timokau July 14, 2020 20:21
@marvin-mk2 marvin-mk2 bot added awaiting_merger (old Marvin label, do not use) and removed needs_merger (old Marvin label, do not use) labels Jul 14, 2020
timokau
timokau requested changes Jul 14, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the commit-message part of CONTRIBUTING.md. This PR should consist of two commits:

maintainers: add mcbeth
spigot: init at 20200101

pkgs/tools/misc/spigot/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/spigot/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/spigot/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/spigot/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/spigot/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/spigot/default.nix Outdated Show resolved Hide resolved
@marvin-mk2 marvin-mk2 bot added awaiting_changes (old Marvin label, do not use) awaiting_reviewer (old Marvin label, do not use) and removed awaiting_merger (old Marvin label, do not use) awaiting_changes (old Marvin label, do not use) labels Jul 14, 2020
@mcbeth mcbeth requested a review from alyssais as a code owner July 15, 2020 12:42
@turion
Copy link
Contributor

turion commented Jul 15, 2020

Thanks @timokau for the thorough look, I also learned a lot about what to look at through that.

@mcbeth mcbeth requested review from timokau and removed request for nbp, FRidh, alyssais, Profpatsch, jonringer, WilliButz and infinisil July 15, 2020 14:11
turion
turion requested changes Jul 15, 2020
View reviewed changes
pkgs/tools/misc/spigot/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/spigot/default.nix Show resolved Hide resolved
@marvin-mk2 marvin-mk2 bot added awaiting_changes (old Marvin label, do not use) awaiting_reviewer (old Marvin label, do not use) and removed awaiting_reviewer (old Marvin label, do not use) awaiting_changes (old Marvin label, do not use) labels Jul 15, 2020
timokau
timokau requested changes Jul 15, 2020
View reviewed changes
pkgs/tools/misc/spigot/default.nix Outdated Show resolved Hide resolved
@marvin-mk2 marvin-mk2 bot added awaiting_changes (old Marvin label, do not use) and removed awaiting_reviewer (old Marvin label, do not use) labels Jul 15, 2020
@marvin-mk2 marvin-mk2 bot added awaiting_reviewer (old Marvin label, do not use) and removed awaiting_changes (old Marvin label, do not use) labels Jul 15, 2020
timokau
timokau approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and welcome to the team!

@timokau timokau merged commit e3acb24 into NixOS:master Jul 15, 2020
@mcbeth mcbeth deleted the spigot branch July 16, 2020 11:53
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turion turion turion requested changes

@timokau timokau timokau approved these changes

@andir andir Awaiting requested review from andir

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@edolstra edolstra Awaiting requested review from edolstra

@edwtjo edwtjo Awaiting requested review from edwtjo

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

@mmahut mmahut Awaiting requested review from mmahut

@peti peti Awaiting requested review from peti

@rycee rycee Awaiting requested review from rycee

@tfc tfc Awaiting requested review from tfc

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle! awaiting_reviewer (old Marvin label, do not use) marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcbeth @turion @timokau @Janik-Haag