Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitea: build package with go 1.13 #87115

Closed
wants to merge 1 commit into from
Closed

gitea: build package with go 1.13 #87115

wants to merge 1 commit into from

Conversation

florianjacob
Copy link
Contributor

as gitea 1.11 does not support go 1.14

Motivation for this change

This repairs the gitea wiki on NixOS 20.03, and therefore should be backported.
See go-gitea/gitea#10552 for upstream issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@florianjacob
gitea: build package with go 1.13
893111d 
as gitea 1.11 does not support go 1.14
This repairs the gitea wiki on NixOS 20.03.
See go-gitea/gitea#10552 for upstream issue.
@florianjacob
Copy link
Contributor Author

@GrahamcOfBorg test gitea

@florianjacob
Copy link
Contributor Author

maintainers: It seemed to me like this is the most viable approach, as I coudl not see how this could/should be changed inside the package, even if the change is tied to the actual gitea version.
However, remembering to remove this on next major version will be hard, I guess. 😅

@florianjacob
Copy link
Contributor Author

Uuhm where did go 1.13 go in master? 🤔
Ah, there it did: #86036

Ma27
Ma27 reviewed May 6, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Go 1.13 is gone, any reason we're not just applying go-gitea/gitea#10583 here?

kolaente
kolaente reviewed May 6, 2020
View reviewed changes
Copy link
Member

@kolaente kolaente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine for now, but Gitea 1.12 will be released relatively soon - when updating that, this workaround could be removed.

@Ma27
Copy link
Member

Ma27 commented May 7, 2020

This seems fine for now, but Gitea 1.12 will be released relatively soon - when updating that, this workaround could be removed.

Well, I'm not sure whether we want to backport Gitea 1.12 and if not, we have to fix this for 1.11 for 20.03 at least. Also, when patching this, the build would fail if the patch doesn't apply anymore (e.g. after an update), right?

@florianjacob does it sound ok to you to only apply the patch which fixes the issue?

@Ma27 Ma27 closed this in 5467751 May 10, 2020
Ma27 added a commit that referenced this pull request May 10, 2020
@Ma27
gitea: 1.11.4 -> 1.11.5
14dd961 
https://github.com/go-gitea/gitea/releases/tag/v1.11.5

Also applying the patch which fixes the wiki-pages, closes #87115.

(cherry picked from commit 5467751)
pvgoran added a commit to pvgoran/nixpkgs that referenced this pull request May 18, 2020
@pvgoran
gitea: fix wiki template incompatibility with go 1.14
64decd9 
Related to NixOS#87115.
@pvgoran pvgoran mentioned this pull request May 18, 2020
Merged
10 tasks
Ma27 pushed a commit that referenced this pull request May 18, 2020
@pvgoran @Ma27
gitea: fix wiki template incompatibility with go 1.14
94492e8 
Related to #87115.

(cherry picked from commit 64decd9)
@florianjacob florianjacob deleted the gitea branch May 18, 2020 14:16
@florianjacob
Copy link
Contributor Author

Thanks to all! Just patching the wiki now and waiting for the imminent gitea 1.12 release is much better. 👍

stigok pushed a commit to stigok/nixpkgs that referenced this pull request Jun 12, 2020
@Ma27 @stigok
gitea: 1.11.4 -> 1.11.5
e5168ed 
https://github.com/go-gitea/gitea/releases/tag/v1.11.5

Also applying the patch which fixes the wiki-pages, closes NixOS#87115.

(cherry picked from commit 5467751)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolaente kolaente kolaente left review comments

@Ma27 Ma27 Ma27 left review comments

@disassembler disassembler Awaiting requested review from disassembler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florianjacob @Ma27 @kolaente